Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: reconcile Kubernetes cluster version #879

Merged
merged 4 commits into from
Jan 9, 2023

Conversation

3u13r
Copy link
Member

@3u13r 3u13r commented Jan 5, 2023

Proposed change(s)

  • Operator now reconciles the Kubernetes cluster version
  • Add additional AwaitingAnnotation Group if the JoiningNode controller hasn't annotated the node yet. This ensures that we don't overwrite annotation once we copy them over from their heir.
  • Add missing PATH to upgrade-agent. This is used for and inside kubeadm.

I tested this on Azure with 1-1 and 3-1 (C-W) nodes.

Checklist

  • Add labels (e.g., for changelog category)
  • Link to Milestone

@netlify
Copy link

netlify bot commented Jan 5, 2023

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 5fa31ba
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/63bbf36d6911d0000896665b

@3u13r 3u13r force-pushed the feat/operator/reconcileKubernetesClusterVersion branch 6 times, most recently from a1b12d2 to de007f1 Compare January 6, 2023 11:08
@3u13r 3u13r mentioned this pull request Jan 6, 2023
9 tasks
@3u13r 3u13r force-pushed the feat/operator/reconcileKubernetesClusterVersion branch 2 times, most recently from 762c2a2 to f673422 Compare January 6, 2023 19:59
@3u13r 3u13r added this to the v.2.5.0 milestone Jan 6, 2023
@3u13r 3u13r marked this pull request as ready for review January 6, 2023 19:59
@3u13r 3u13r requested a review from malt3 January 6, 2023 20:07
Copy link
Contributor

@malt3 malt3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one possible improvement. Otherwise LGTM

@3u13r 3u13r force-pushed the feat/operator/reconcileKubernetesClusterVersion branch from decbbfc to d5a9d53 Compare January 9, 2023 10:56
@3u13r 3u13r force-pushed the feat/operator/reconcileKubernetesClusterVersion branch from d5a9d53 to 5fa31ba Compare January 9, 2023 10:58
@3u13r 3u13r merged commit 2700d51 into main Jan 9, 2023
@3u13r 3u13r deleted the feat/operator/reconcileKubernetesClusterVersion branch January 9, 2023 11:16
@3u13r 3u13r added the feature This introduces new functionality label Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This introduces new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants