image: fix "ignored null byte in input" warning on AWS #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malt3
approved these changes
Jan 17, 2023
|
Missed adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
This has multiple reasons:
tail -c +3072would achieve).Now if we take a closer look at how that struct is defined from Amazon's script, we can find that it is supposed to be 32 bytes long: https://github.com/amazonlinux/amazon-ec2-utils/blob/34294c2fbb37ffd2f2e7d0d82ee8522e7ec3c02d/ebsnvme-id#L50-L51
The remaining response is the "RESERVED" block we are hitting, which is conveniently NULL but could also be something else in the future. Who knows.
So let's do that properly:
Since the whole name struct is initialised with spaces (
\20), we only need to trim those and don't need to trim any NULL bytes additionally.With that, the output should be clean:
Additional info