Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Read actual status code after a POST device API call #471

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

FelixTing
Copy link
Member

@FelixTing FelixTing commented Jul 20, 2023

Also update the discovery example to v3.

fix: #452

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-sdk-c/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

Run EdgeX stack
Comment out the following code snippet:

device-sdk-c/src/c/devman.c

Lines 192 to 196 in e31ab6e

if (existing)
{
edgex_device_release (svc, existing);
continue;
}

Build and run the discovery example (src/c/examples/discovery/template.c)
Add ProvisionWatcher

# at src/c/examples/discovery
curl -X POST [email protected] 0:59881/api/v3/provisionwatcher

Restart the example device service
Should be seeing logs related to device updates

Also update the discovery example to v3.

Signed-off-by: FelixTing <[email protected]>
@FelixTing FelixTing merged commit 80a24b0 into edgexfoundry:main Jul 28, 2023
1 check passed
@FelixTing FelixTing deleted the issue-452 branch July 28, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants