Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Address CVE in Alpine base image #496

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

lenny-goodell
Copy link
Member

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-sdk-c/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@lenny-goodell lenny-goodell added the ci issue_type denoting non-code changes such as testing or compilation label Nov 14, 2023
@lenny-goodell lenny-goodell added this to the Odessa milestone Nov 14, 2023
@lenny-goodell lenny-goodell marked this pull request as draft November 14, 2023 20:28
@lenny-goodell lenny-goodell added the hold Intended for PRs we want to flag for ongoing review label Nov 14, 2023
@lenny-goodell
Copy link
Member Author

On hold as this will be for Odessa since the SDK has been released.

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM it is fine to be merged, but need another PR for napa branch

@lenny-goodell
Copy link
Member Author

LGTM it is fine to be merged, but need another PR for napa branch

@cloudxxx8, I wasn't planning a back port of this on the released SDKs since this is in the example Dockerfiles, which most folks will get from main. branch. Thoughts

@cloudxxx8
Copy link
Member

ok, that's correct

@FelixTing FelixTing marked this pull request as ready for review June 3, 2024 02:37
@FelixTing FelixTing merged commit b5fd43a into edgexfoundry:main Jun 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci issue_type denoting non-code changes such as testing or compilation hold Intended for PRs we want to flag for ongoing review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants