-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:When reading's value is string type, it will be released prematurely #506
Conversation
Issue #493 |
14f0817
to
f823028
Compare
@ych988 Please add "fix: " at the beginning of the commit message to pass Semantic PR checks. In addition, EdgeXFoundry currently requires signed commit. For instructions on setting up a GPG key for signing commits, see https://wiki.edgexfoundry.org/display/FA/Secrets+of+GitHub+Signing%2C+Keys+and+Commits+Setup. |
f823028
to
5e3c3b9
Compare
Signed-off-by: yangc <[email protected]>
5e3c3b9
to
cc6030f
Compare
String values with ownership @ych988 Could you please provide steps to reproduce the issue and describe the scenario in which the problem occurred? |
This problem is not easy to reproduce. Because if the released memory data area is not overwritten when data is uploaded, the problem will not occur. |
@ych988 May I ask which EdgeX device service you are using? |
Sorry, My service depends on the device environment. This might be useful. [ "name": "doorStatusCtr", |
Thanks for the information. I will test this with an existing edgex device service. |
Verified this fix with device-bacnet. This fix also applies to GET commands for string type resources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
When reading's value is string type, it will be released prematurely.
ae_runner → edgex_data_process_event → devsdk_commandresult_free
string of IOT_DATA_REF will be release prematurely by devsdk_commandresult_free