Featuring cmake, more friendly to EPL 2.0 project #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS property to automatically create a module definition (.def) file with all global symbols found in the input .obj files for a SHARED library.
Not sure we have a legal standing to redistribute it, users can download it from other sources.
Including to CTransaction class and disable CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS
|
Hi, I only just noticed this PR. It's been a while since I've programmed on Windows. My main concern is that some beginner developers may feel intimidated by their unfamiliarity with CMake. However, adding some instructions to the README should suffice. Regardless, using CMake seems to be a better solution. I will review the code, perform some basic builds/tests, update the README, and aim to merge this PR as soon as possible. |
|
ok, LGTM. I may update some readme later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ease of development, I switch this project as a cmake project. We can configure the project via CMake GUI app and then open the result in Visual Studio or directly open the project in Visual Studio Code (with C/C++ Extension Pack installed). I also remove the OPC Core Component because I'm not sure we have a legal standing to distribute it. The main reason for this change is so I can dynamically link the OPCClientToolKit (LGPL 3.0) library to 4diac FORTE (EPL 2.0) without any issue.