Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Windows path overrides are broken #184

Merged
merged 1 commit into from
Apr 2, 2024
Merged

fix: Windows path overrides are broken #184

merged 1 commit into from
Apr 2, 2024

Conversation

greut
Copy link
Member

@greut greut commented Apr 2, 2024

mstruebing
mstruebing reviewed Apr 2, 2024
View reviewed changes
Copy link
Contributor

@mstruebing mstruebing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure, do you think this is the right place to fix this or should this rather happen in the consumer (editorconfig-checker)? 

@greut
Copy link
Member Author

greut commented Apr 2, 2024

@mstruebing sadly, it's turning relative paths into absolute paths which creates a mess on Windows. The other checkers have the same issue.

@greut greut merged commit a5a5d12 into master Apr 2, 2024
5 checks passed
@greut greut deleted the fix/windows-paths branch April 2, 2024 11:20
@greut greut mentioned this pull request Apr 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstruebing mstruebing mstruebing left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greut @mstruebing