-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't skip acwrite buffers #188
Don't skip acwrite buffers #188
Conversation
Prior to this change, the editorconfig-vim will skip processing any non-'normal' buffer, and the idea behind this is that we would not want it to mess around with, say, 'help' or 'quickfix' buffers. However, 'acwrite' buffers act pretty much like any other 'normal' buffer, with custom filetypes and all; the only difference is that 'acwrite' buffers will always be writtein with BufWriteCmd autocommands (see `:h buftype`). Because of this, I have changed editorconfig-vim to skip processing buffers which are not 'normal' (i.e., empty buftype), or 'acwrite'.
Thanks --- I had never heard of |
I am not sure -- how do I run the plugin tests? |
@iamFIREcracker On a unix-like system, you should be able to do |
@cxw42 sorry for the late reply -- you know, life... I gave it a go this morning, but could not get it to work, so I am afraid I am going to need your help. OS: Output of
Output of the test runner:
Vim's
|
@iamFIREcracker thanks for giving it a try --- that is weird! I am not sure why you saw a failure. The only thing I noticed is that your commit is off Log of my test run after cherry-picking this commit
|
Hey, thanks lots for getting this merged. And yeah, I am not sure what was I thinking, when I decided to create a PR off of a very old version of master...my bad! |
Prior to this change, the editorconfig-vim will skip processing any
non-'normal' buffer, and the idea behind this is that we would not want
it to mess around with, say, 'help' or 'quickfix' buffers.
However, 'acwrite' buffers act pretty much like any other 'normal'
buffer, with custom filetypes and all; the only difference is that
'acwrite' buffers will always be writtein with BufWriteCmd autocommands
(see
:h buftype
).Because of this, I have changed editorconfig-vim to skip processing
buffers which are not 'normal' (i.e., empty buftype), or 'acwrite'.