Fix git ahead/behind count on zsh #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@{upstream}...HEAD needs to be quoted else zsh eats it.
[ ! $only_if_ssh ] only tests if the length of the string is non-zero. So setting it to 0 or 1 resulted in it always being true. Switch to a more standard boolean check, pulled from: http://stackoverflow.com/questions/2953646/how-to-declare-and-use-boolean-variables-in-shell-script
|
Apparently I don't understand how pull requests work on github. Made a second fix for the only_if_ssh check on the host slice and somehow it became a part of this pull request. Should be pulled also but not sure how it automatically became part of this PR. |
|
Hm.. I can't reproduce. Which version of zsh are you using? |
|
Installed via homebrew. Also saw the same on a Fedora 20 Workstation with zsh version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@{upstream}...HEAD needs to be quoted else zsh eats it.