Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useFetcher examples #203

Merged
merged 3 commits into from
Jul 8, 2023
Merged

useFetcher examples #203

merged 3 commits into from
Jul 8, 2023

Conversation

jeyj0
Copy link
Contributor

@jeyj0 jeyj0 commented Jul 3, 2023

As mentioned in #192, I added a useFetcher variant for all react-router and remix examples.

The remix examples additionally fall back to useActionData, which allows the form to still work great with javascript disabled, I found.

The examples are essentially copy-paste from the non-useFetcher versions otherwise.

I also added links to the new routes in the root route.

edmundhung
edmundhung approved these changes Jul 8, 2023
View reviewed changes
Copy link
Owner

@edmundhung edmundhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on it! I have kept only the login form example as the solution is no different.

@edmundhung edmundhung merged commit 52aa84f into edmundhung:main Jul 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmundhung edmundhung edmundhung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeyj0 @edmundhung