Update internal race value to 64 bit #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edo9300
added a commit
to edo9300/edopro
that referenced
this pull request
Aug 31, 2022
edo9300
added a commit
to DyXel/Multirole
that referenced
this pull request
Aug 31, 2022
edo9300
added a commit
to edo9300/edopro
that referenced
this pull request
Sep 3, 2022
Apply the required message changes needed to properly handle higher race values, to match with edo9300/ygopro-core#127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump the race value size from 32 to 64 bit, giving us 32 new race values.
This is needed to futureproof the new upcoming rush card types, that could end up making the card types become more than 32.
This change breaks both the core abi and the messages.
For the abi now the
racefield in theOCG_CardDatastruct changed from uint32_t to uint64_t.For the messages,
QUERY_RACEwill now be an uint64_t instead of uint32_t,MSG_ANNOUNCE_RACEwill send an uint64_t for the races that can be declared, and also will now expect an uint64_t as answer, also, theHINT_RACEproperty associated withMSG_HINTwill be using the full uint64_t data field as well.