Crash: opds publicationInfoA11y Component crash with strictNullChecks issue

[panaC]

1d48f88#diff-c5ec05104b3b03043bf6ce4a94909efdf62885f1d6799649fe183076a3ee6cd2R59-R60

https://rawcdn.githack.com/edrlab/thorium-reader-epub-tests/main/EPUB_Feeds_for_testing_purpose/opds-rare-epub-suit.json

[danielweck]

the OPDS link above does not trigger the bug because the accessModeSufficient was removed.

[panaC]

the OPDS link above does not trigger the bug because the accessModeSufficient was removed.

https://raw.githack.com/edrlab/publications/85f16df059d19d1bfad254b1dbd8990a29f39ce2/feeds/thorium3_documentation.json

[danielweck]

this link points to an invalid OPDS feed (not conforming to the JSON Schema) where accessModeSufficient is not an array.
(in this case, the crash isn't in Thorium, it is in the low-level parser which doesn't tolerate non-array property value)

[danielweck]

see: edrlab/publications@c4f2019

[danielweck]

accessModeSufficient is an array of string arrays ... but the string arrays containing a single item can be reduced to a string value.

JSON Schema:
https://github.com/readium/webpub-manifest/blob/03d7681cf1ff689bad76efaabc9c77423296a94c/schema/a11y.schema.json#L54-L82

[panaC]

7eae5aa

[panaC]

It was fixed with this commit : 7eae5aa

Works with https://rawcdn.githack.com/edrlab/thorium-reader-epub-tests/main/EPUB_Feeds_for_testing_purpose/opds-rare-epub-suit.json

I'm closing the issue, feel free to reopen it @gautierchomel
Thanks

[danielweck]

can we please test with a real world example like this:

accessModeSufficient: [ ["textual", "visual"], "textual" ]

and

accessModeSufficient: [ ["textual", "visual"], ["textual"] ]

http://kb.daisy.org/publishing/docs/metadata/schema.org/accessModeSufficient.html

thank you :)

(ps: instead of hand-crafting an OPDS feed for each case, maybe just force the values in Thorium post-parsing, pre-JSX?)

[panaC]

can we please test with a real world example like this:

accessModeSufficient: [ ["textual", "visual"], "textual" ]

and

accessModeSufficient: [ ["textual", "visual"], ["textual"] ]

http://kb.daisy.org/publishing/docs/metadata/schema.org/accessModeSufficient.html

thank you :)

(ps: instead of hand-crafting an OPDS feed for each case, maybe just force the values in Thorium post-parsing, pre-JSX?)

const findStrInArrayArray = (array: string[][] | string[] | undefined, str: string): boolean => Array.isArray(array) && array.findIndex((a) => (Array.isArray(a) ? a : [a]).findIndex((b) => b === str) > -1) > -1;

check on type : undefined | string[] | (string | string[])[]

Seems good, the issue throws by Gautier seems to be a misleading between the type string and string[].