Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(cmake) Update qt macro usage #44

Merged
merged 3 commits into from
Dec 21, 2023
Merged

(cmake) Update qt macro usage #44

merged 3 commits into from
Dec 21, 2023

Conversation

csparker247
Copy link
Member

@csparker247 csparker247 commented Oct 27, 2023 •
edited
Loading

Replaces FILENAME_VARIABLE with OUTPUT_SCRIPT in all usages of qt_generate_deploy_app_script.

Fixes the following CMake warning:

CMake Warning (dev) at /opt/homebrew/opt/qt/lib/cmake/Qt6Core/Qt6CoreMacros.cmake:2992 (message):
  The FILENAME_VARIABLE keyword is deprecated and will be removed soon.
  Please use OUTPUT_SCRIPT instead.

@csparker247 csparker247 marked this pull request as draft October 27, 2023 13:15
@csparker247
Copy link
Member Author

This requires Qt 6.5+. Since that isn't available on all of our targeted development platforms, I'm going to set this to draft and come back to it in the future.

@csparker247 csparker247 added the stalled Not being worked on or waiting for external factors label Oct 27, 2023
@csparker247 csparker247 marked this pull request as ready for review December 21, 2023 01:45
@csparker247 csparker247 removed the stalled Not being worked on or waiting for external factors label Dec 21, 2023
@csparker247 csparker247 marked this pull request as draft December 21, 2023 01:53
@csparker247 csparker247 marked this pull request as ready for review December 21, 2023 02:00
@csparker247 csparker247 merged commit be77dc0 into develop Dec 21, 2023
2 checks passed
@csparker247 csparker247 deleted the qt-output-script branch December 21, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@csparker247