Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for shading over InputStream #3

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

joan38
Copy link
Contributor

@joan38 joan38 commented Aug 17, 2020

@eed3si9n
Copy link
Owner

Looks like Travis CI is failing:

[info] [error] java.nio.file.DirectoryNotEmptyException: /tmp/sbt_364ea5eb/two/shadedJawn/target/scala-2.12/shaded
[info] [error] 	at java.base/sun.nio.fs.UnixFileSystemProvider.implDelete(UnixFileSystemProvider.java:243)
[info] [error] 	at java.base/sun.nio.fs.AbstractFileSystemProvider.delete(AbstractFileSystemProvider.java:105)
[info] [error] 	at java.base/java.nio.file.Files.delete(Files.java:1141)
[info] [error] 	at com.eed3si9n.jarjarabrams.Shader$.$anonfun$shadeDirectory$3(Shader.scala:17)
[info] [error] 	at com.eed3si9n.jarjarabrams.Shader$.$anonfun$shadeDirectory$3$adapted(Shader.scala:17)
[info] [error] 	at scala.collection.Iterator.foreach(Iterator.scala:941)
[info] [error] 	at scala.collection.Iterator.foreach$(Iterator.scala:941)
[info] [error] 	at scala.collection.AbstractIterator.foreach(Iterator.scala:1429)
[info] [error] 	at scala.collection.IterableLike.foreach(IterableLike.scala:74)
[info] [error] 	at scala.collection.IterableLike.foreach$(IterableLike.scala:73)
[info] [error] 	at scala.collection.AbstractIterable.foreach(Iterable.scala:56)
[info] [error] 	at com.eed3si9n.jarjarabrams.Shader$.shadeDirectory(Shader.scala:17)

You might have to delete recursively.

@joan38 joan38 force-pushed the input-stream branch 3 times, most recently from a543a49 to 4d6313a Compare August 17, 2020 21:52
@joan38
Copy link
Contributor Author

joan38 commented Aug 17, 2020

@eed3si9n I ended up replicating exactly the previous behavior by removing only files.

@eed3si9n eed3si9n merged commit 8a9a9d6 into eed3si9n:master Aug 18, 2020
@joan38 joan38 deleted the input-stream branch August 18, 2020 02:18
@joan38
Copy link
Contributor Author

joan38 commented Aug 18, 2020

Thanks @eed3si9n. Are you planning to make a release out of this?

@eed3si9n
Copy link
Owner

Yea. Let's do it.

@eed3si9n
Copy link
Owner

Oh no did you use JDK 9+ stuff? I don't want sbt-assembly to require JDK 9+.

[error] /Users/eed3si9n/work/jarjar-abrams/core/src/main/scala/com/eed3si9n/jarjarabrams/Shader.scala:21:36: value readAllBytes is not a member of java.io.InputStream
[error]       Files.write(out, inputStream.readAllBytes(), StandardOpenOption.CREATE)

@joan38
Copy link
Contributor Author

joan38 commented Aug 18, 2020

Yes.
Ok let me create another PR to do differently.

@joan38
Copy link
Contributor Author

joan38 commented Aug 18, 2020

Have a look at #5

@eed3si9n
Copy link
Owner

https://github.com/eed3si9n/jarjar-abrams/releases/tag/v0.2.0 is on its way to Maven Central.

@joan38
Copy link
Contributor Author

joan38 commented Aug 18, 2020

Nice! Thanks @eed3si9n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants