Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Deps]: ember 3.16 && node 10 upgrade #19

Merged
merged 2 commits into from
Sep 7, 2020
Merged

[Deps]: ember 3.16 && node 10 upgrade #19

merged 2 commits into from
Sep 7, 2020

Conversation

snewcomer
Copy link
Collaborator

@snewcomer snewcomer commented Sep 7, 2020 •
edited
Loading

  • node 10
  • 3.16 + change to test suite to run > 3.12
  • Add tests for mixin w/ class Model

ember-data relies on external partner tests for its CI suite. The result of a new change to convert our Model class to native classes also requires the external partner tests to follow suite.

emberjs/data#7226

@snewcomer snewcomer mentioned this pull request Sep 7, 2020
Merged
@ef4
Copy link
Owner

ef4 commented Sep 7, 2020

Thanks, please feel free to merge and release.

@snewcomer snewcomer merged commit 2b8fd6d into ef4:master Sep 7, 2020
@snewcomer snewcomer deleted the sn/3.16 branch September 7, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ef4 ef4 ef4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snewcomer @ef4