Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: improve user input handling by detecting command text #16

Merged
merged 2 commits into from
Apr 2, 2023

Conversation

efJerryYang
Copy link
Owner

This commit improves the user input handling by detecting the command text at the user_input function. Previously, the input process did not differentiate between command and regular text, requiring the user to press Enter twice to signal the end of input for both cases. With this update, the command text can be directly parsed and executed with the first Enter key press.

This commit improves the user input handling by detecting the command text
at the `user_input` function. Previously, the input process did not differentiate
between command and regular text, requiring the user to press Enter twice
to signal the end of input for both cases. With this update, the command text
can be directly parsed and executed with the first Enter key press.
@efJerryYang
Copy link
Owner Author

Hi @PraxTube, could you help me review the functionality when you have some free time? I believe there's a great need to check the pull requests before merging them, especially when we haven't implemented the testing part.

@PraxTube
Copy link
Collaborator

PraxTube commented Apr 1, 2023

Absolutely, I would love to help. I also really like this addition.

@efJerryYang
Copy link
Owner Author

Great, I will merge this PR tomorrow morning if nothing goes wrong.

@PraxTube
Copy link
Collaborator

PraxTube commented Apr 1, 2023

No objections. The changes look good to me.

@efJerryYang efJerryYang merged commit 32fc824 into main Apr 2, 2023
@efJerryYang efJerryYang deleted the feat-improve-user-input-handling branch April 2, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants