Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dockerfiles #59

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

teofr
Copy link
Contributor

@teofr teofr commented Jun 10, 2024

I think it could ease up some changes to infrastructure rather than individual systems.
For example, using hyperfine for arm64 rather than amd at some point.

@dhil
Copy link
Contributor

dhil commented Jun 10, 2024

Interesting, thanks!

@teofr teofr marked this pull request as ready for review June 10, 2024 19:13
@teofr
Copy link
Contributor Author

teofr commented Jun 11, 2024

Marked it as ready for review, not sure why I made it a draft before.

@dhil dhil self-requested a review June 11, 2024 11:19
Copy link
Contributor

@dhil dhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dhil dhil merged commit 6e4c3bf into effect-handlers:main Jun 11, 2024
8 checks passed
@teofr teofr deleted the refactor_dockerfiles branch July 12, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants