Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This pull request adds an option in the samba-client constructor to mask command by passing
maskCmd: true
.This flag defaults to
false
in order to not disturb any existing functionality.I've tested it with a few error cases. Differences are shown below:
(1): Incorrect Network name:
maskCmd: false
maskCmd: true
(2): Incorrect credentials
maskCmd: false
maskCmd: true
(3): smbclient not installed
maskCmd: false
maskCmd: true
I eagerly await any feedback on this PR. Thanks in advance!
Closes #32