Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support directory in client options #57

Merged
merged 1 commit into from
Apr 15, 2023
Merged

support directory in client options #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ declare module "samba-client" {
readonly password?: string;
readonly domain?: string;
readonly port?: number;
readonly directory?: string;
readonly timeout?: number;
readonly maxProtocol?: string;
readonly maskCmd?: boolean;
Expand Down
5 changes: 5 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ class SambaClient {
this.password = options.password;
this.domain = options.domain;
this.port = options.port;
this.directory = options.directory;
this.timeout = options.timeout;
// Possible values for protocol version are listed in the Samba man pages:
// https://www.samba.org/samba/docs/current/man-html/smb.conf.5.html#CLIENTMAXPROTOCOL
Expand Down Expand Up @@ -146,6 +147,10 @@ class SambaClient {
args.push("-W", this.domain);
}

if (this.directory) {
args.push("-D", this.directory);
}

if (this.maxProtocol) {
args.push("--max-protocol", this.maxProtocol);
}
Expand Down