fix: convert unhandled rejection to uncaught exception (#235) #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fengmk2
approved these changes
Aug 7, 2023
|
@killagu lint 修复一下就好了。 |
Mocha do not catch unhandled rejection by default. Case will faield until timeout. set `--unhandled-rejections` to strict, let case fail fast.
killagu
force-pushed
the
backport/fix/unhandled-rejection
branch
from
1de71ee
to
489afd8
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## 5.x #236 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 93 93
Branches 16 16
=========================================
Hits 93 93 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mocha do not catch unhandled rejection by default. Case will faield until timeout. set
--unhandled-rejectionsto strict, let case fail fast.Checklist
npm testpassesAffected core subsystem(s)
Description of change