Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wait 5s when master exit #60

Merged
merged 4 commits into from
Mar 27, 2018
Merged

fix: wait 5s when master exit #60

merged 4 commits into from
Mar 27, 2018

Conversation

popomore
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@codecov
Copy link

codecov bot commented Mar 22, 2018 •
edited
Loading

Codecov Report

Merging #60 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   98.28%   98.29%   +<.01%     
==========================================
  Files           7        7              
  Lines         408      410       +2     
==========================================
+ Hits          401      403       +2     
  Misses          7        7
Impacted Files Coverage Δ
lib/master.js 98.31% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c71f693...581b465. Read the comment docs.

@popomore
Copy link
Member Author

eggjs/egg-bin#88

@popomore popomore requested a review from fengmk2 March 27, 2018 03:51
@atian25 atian25 mentioned this pull request Mar 27, 2018
Merged
4 tasks
@popomore popomore merged commit 9e57453 into master Mar 27, 2018
@popomore popomore deleted the wait-5s branch March 27, 2018 04:36
@atian25
Copy link
Member

atian25 commented Mar 28, 2018

1.16.0

@nightink nightink mentioned this pull request Apr 13, 2018
Merged
4 tasks
hyj1991 pushed a commit to hyj1991/egg-cluster that referenced this pull request Jun 6, 2022
@popomore
fix: wait 5s when master exit (eggjs#60)
6055949
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atian25 atian25 atian25 approved these changes

@fengmk2 fengmk2 Awaiting requested review from fengmk2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@popomore @atian25