Facility dynamic generate for source microplan

[nitish-egov]

No description provided.

[coderabbitai]

Warning

Review failed

The pull request is closed.

Walkthrough

Walkthrough

The recent updates to the createFacilitySheet function in genericUtils.ts involve conditional schema fetching. When the result of checkIfSourceIsMicroplan is true, the function now calls callMdmsTypeSchema with an argument "microplan" or "microplan3" to fetch the appropriate schema.

Changes

File	Change Summary
utilities/.../src/server/utils/genericUtils.ts	Updated createFacilitySheet to conditionally fetch schema based on checkIfSourceIsMicroplan.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Server
    participant Utils
    participant SchemaService

    User->>Server: Request to create facility sheet
    Server->>Utils: Call createFacilitySheet(request, allFacilities, localizationMap)
    Utils->>Utils: Call checkIfSourceIsMicroplan(request)
    alt isSourceMicroplan is true
        Utils->>SchemaService: Call callMdmsTypeSchema("microplan")
    else isSourceMicroplan is false
        Utils->>SchemaService: Call callMdmsTypeSchema()
    end
    SchemaService-->>Utils: Return schema
    Utils-->>Server: Return facility sheet
    Server-->>User: Send facility sheet response

Loading

Poem

In the world of code so bright,
Function changes bring delight.
Conditional schema fetch in sight,
Microplans now set just right.
Celebrate with cheers and might,
For utils shine with newfound light! 🚀

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f00410f and b153efe.

Files selected for processing (1)

• utilities/project-factory/src/server/utils/genericUtils.ts (1 hunks)

Additional comments not posted (3)

utilities/project-factory/src/server/utils/genericUtils.ts (3)

466-466: Verify the response structure from getCampaignSearchResponse.

Ensure that responseFromCampaignSearch contains the expected structure, especially CampaignDetails, before accessing it.

---

467-467: Check for microplan source.

checkIfSourceIsMicroplan should correctly identify if the source is "microplan". Verify the logic within this function.

---

468-473: Conditional schema fetching logic is sound.

The logic to fetch the schema based on the source type is implemented correctly. Ensure that callMdmsTypeSchema handles the additional argument "microplan3" properly.