Enhance Microplan Assumptions Screen with Validations and UI Improvements #1403

Bhargav-egov · 2024-09-19T08:48:13Z

Refactored the code for better readability and maintainability.
-Implemented dropdown functionality for add new assumption feature.
-Added validation checks to ensure all mandatory fields are filled before.
Updated the UI to enhance usability and ensure consistency.
Fixed issues related to assumption handling and deletion functionality.

…vements

coderabbitai · 2024-09-19T08:48:21Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Base branches to auto review (7)

master
develop
hcm-test
mf-build-docker
base-hcm-workbench
microplan
campaign

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-- I pushed a fix in commit <commit_id>, please review it.
-- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
-- @coderabbitai generate unit testing code for this file.
-- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
-- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
-- @coderabbitai read src/utils.ts and generate unit testing code.
-- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
-- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

nipunarora-eGov · 2024-09-19T08:56:39Z

health/micro-ui/web/micro-ui-internals/packages/css/src/components/microplanning.scss

@@ -1313,7 +1313,7 @@ $border-color: rgba(214, 213, 212, 1);
      .equal-to-icon {
        margin: 0 3%;
        font-family: Roboto Condensed;
-        font-size: 2.5rem;
+        font-size: 5rem;


@Bhargav-egov this might affect others

nipunarora-eGov · 2024-09-19T08:57:12Z

health/micro-ui/web/micro-ui-internals/packages/css/src/pages/employee/index.scss

@@ -553,16 +553,12 @@ tbody {
 .digit-card-component.bannerCard.removeBottomMargin.languageSelection{
  width: unset !important;


why changes in this file

nipunarora-eGov · 2024-09-19T08:57:35Z

...o-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/CampaignName.js

@@ -18,9 +18,10 @@ const CampaignName = ({ onSelect, formData, control, formState, ...props }) => {
    if (props?.props?.isSubmitting && !name) {
      setError({ message: "CAMPAIGN_FIELD_ERROR_MANDATORY" });
    } else {
-      setError(null);
+      setError(null);  


revert any change in campaign manger/ folder

nipunarora-eGov · 2024-09-19T08:57:54Z

...o-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/CampaignType.js

@@ -96,7 +96,7 @@ const CampaignSelection = ({ onSelect, formData, formState, ...props }) => {
          <div>{t(`CAMPAIGN_TYPE_${beneficiaryType}`)}</div>
        </LabelFieldPair>


nipunarora-eGov · 2024-09-19T08:59:50Z

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/ManageData.js

+import { Header, LoaderWithGap } from "@egovernments/digit-ui-react-components";
+import React, { useRef, useState, useEffect, Fragment } from "react";
+import { useTranslation } from "react-i18next";
+import { Card, Modal, CardText } from "@egovernments/digit-ui-react-components";


This file is not required

nipunarora-eGov · 2024-09-19T09:00:05Z

...ro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/SetupMicroplan.js

@@ -81,7 +81,8 @@ const SetupMicroplan = () => {
  }, [params]);

  const onSubmit = (formData) => {
-
+    console.log(formData)


remove logs and debuggers

nipunarora-eGov · 2024-09-19T09:00:22Z

micro-ui/web/micro-ui-internals/packages/modules/pgr/src/pages/employee/ComplaintDetails.js

@@ -468,7 +468,7 @@ export const ComplaintDetails = (props) => {
        )}
      </Card>
      {fullscreen ? (
-        <PopUp>
+        <PopUp >


remove this change

nipunarora-eGov

Pls make requested changes

into bhargav-sample

Bhargav-egov added 2 commits September 13, 2024 12:55

microplan assumptions screen

e00ad40

update microplan assumptions screen with enhanced logics and UI impro…

83960f8

…vements

nipunarora-eGov reviewed Sep 19, 2024

View reviewed changes

nipunarora-eGov requested changes Sep 19, 2024

View reviewed changes

Bhargav-egov added 2 commits September 19, 2024 16:56

resolved some changes

f803525

Merge branch 'console' of https://github.com/egovernments/DIGIT-Frontend

b5ea97b

into bhargav-sample

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhance Microplan Assumptions Screen with Validations and UI Improvements #1403

Enhance Microplan Assumptions Screen with Validations and UI Improvements #1403

Bhargav-egov commented Sep 19, 2024

coderabbitai bot commented Sep 19, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

nipunarora-eGov Sep 19, 2024

nipunarora-eGov Sep 19, 2024

nipunarora-eGov Sep 19, 2024

nipunarora-eGov Sep 19, 2024

nipunarora-eGov Sep 19, 2024

nipunarora-eGov Sep 19, 2024

nipunarora-eGov Sep 19, 2024

nipunarora-eGov left a comment

		@@ -553,16 +553,12 @@ tbody {
		.digit-card-component.bannerCard.removeBottomMargin.languageSelection{
		width: unset !important;

		@@ -96,7 +96,7 @@ const CampaignSelection = ({ onSelect, formData, formState, ...props }) => {
		<div>{t(`CAMPAIGN_TYPE_${beneficiaryType}`)}</div>
		</LabelFieldPair>

Enhance Microplan Assumptions Screen with Validations and UI Improvements #1403

Are you sure you want to change the base?

Enhance Microplan Assumptions Screen with Validations and UI Improvements #1403

Conversation

Bhargav-egov commented Sep 19, 2024

coderabbitai bot commented Sep 19, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

nipunarora-eGov Sep 19, 2024

Choose a reason for hiding this comment

nipunarora-eGov Sep 19, 2024

Choose a reason for hiding this comment

nipunarora-eGov Sep 19, 2024

Choose a reason for hiding this comment

nipunarora-eGov Sep 19, 2024

Choose a reason for hiding this comment

nipunarora-eGov Sep 19, 2024

Choose a reason for hiding this comment

nipunarora-eGov Sep 19, 2024

Choose a reason for hiding this comment

nipunarora-eGov Sep 19, 2024

Choose a reason for hiding this comment

nipunarora-eGov left a comment

Choose a reason for hiding this comment

CodeRabbit Configuration File (`.coderabbit.yaml`)