fixed app delivery condition

[Bhavya-egov]

Summary by CodeRabbit

• New Features

  • Updated step labels in the Stepper component for improved clarity in the boundary selection and campaign setup processes.
  • Enhanced campaign setup functionality with refined data handling and improved error management.

• Bug Fixes

  • Improved error handling and validation checks during the campaign submission process.

• Documentation

  • No changes to the declarations of exported or public entities were made.

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The pull request introduces several modifications across multiple components in the campaign management module. Key changes include updates to the customSteps prop in the Stepper component of both BoundarySummary and SelectingBoundariesDuplicate, reflecting a semantic update in the step names. Additionally, the SetupCampaign component has been enhanced with improved API interaction and error handling, while the setupCampaignHelpers utility functions have been updated to accommodate a new parameter that influences data processing logic.

Changes

File Path	Change Summary
.../BoundarySummary.js	Updated customSteps prop in Stepper from ["HCM_BOUNDARY_DETAILS", "HCM_SUMMARY"] to ["HCM_BOUNDARY_DETAILS_VERTICAL", "HCM_SUMMARY"].
.../SelectingBoundariesDuplicate.js	Updated customSteps prop in Stepper from ["HCM_BOUNDARY_DETAILS", "HCM_SUMMARY"] to ["HCM_BOUNDARY_DETAILS_VERTICAL", "HCM_SUMMARY"].
.../SetupCampaign.js	Enhanced campaign data handling and API interactions. Added parameters to payloadData, refined currentKey logic, improved error handling, and updated onSubmit function for better validation and state management.
.../setupCampaignHelpers.js	Updated function signatures for restructureData, processDelivery, and processDoseCriteria to include a new type parameter, altering how conditions are processed based on the operation type.

Possibly related PRs

• Vertical stepper implemenetation #1441: The changes in the Stepper component in both the main PR and this PR involve modifications to the customSteps prop, indicating a direct relationship in the handling of stepper navigation.
• Boundary screen #1451: The CampaignBoundary component in this PR may relate to the changes in the BoundarySummary component in the main PR, as both involve boundary management and user interface updates.
• updated summary redirection #1488: The updates to the BoundarySummary component in this PR include the addition of a hierarchyType property, which aligns with the changes made in the main PR regarding the Stepper component.
• fixed NA issue of summary #1681: The modifications in the SetupCampaign component regarding the handling of campaign cycle configuration and delivery data restructuring relate to the changes in the Stepper component in the main PR, as both involve campaign setup processes.
• changes in the delivery type and selection of boundary #1816: The changes in the SelectingBoundaryComponent regarding boundary selection logic and validation are related to the updates in the BoundarySummary component in the main PR, as both focus on boundary management and user interactions.

Suggested reviewers

• jagankumar-egov

Poem

In the garden of steps, we hop and we play,
With boundaries shifting, we brighten the day.
From details to summaries, we dance with delight,
Crafting campaigns that shine ever so bright!
So here’s to the changes, both big and small,
A leap for our users, let’s celebrate all! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.