Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed warning toast #748

Merged
merged 2 commits into from
May 30, 2024
Merged

fixed warning toast #748

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fda7e21
fixed warning toast
Bhavya-egov May 30, 2024
f0aa6c3
Update UploadData.js
Bhavya-egov May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/UploadData.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ const UploadData = ({ formData, onSelect, ...props }) => {
const [translatedSchema, setTranslatedSchema] = useState({});
const [readMeInfo, setReadMeInfo] = useState({});
const [enabled, setEnabled] = useState(false);
const currentKey = searchParams.get("key");


useEffect(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specify all dependencies in useEffect to avoid unintended re-renders.

- }, [uploadedFile, isError, isValidation, apiError, isSuccess]);
+ }, [uploadedFile, isError, isValidation, apiError, isSuccess, onSelect, type]);
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
useEffect(() => {
useEffect(() => {
// effect logic here
}, [uploadedFile, isError, isValidation, apiError, isSuccess, onSelect, type]);

if (type === "facilityWithBoundary") {
Expand Down Expand Up @@ -795,6 +797,10 @@ const UploadData = ({ formData, onSelect, ...props }) => {
}
}, [showToast]);

useEffect(() => {
setShowToast(null);
}, [currentKey]);

return (
<>
{isValidation && <LoaderWithGap text={"CAMPAIGN_VALIDATION_INPROGRESS"} />}
Expand Down
Loading