Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added changelog and upgraded the versions for household, individual a… #874

Closed
wants to merge 7 commits into from

Conversation

kanishq-egov
Copy link
Contributor

@kanishq-egov kanishq-egov commented Aug 29, 2024

…nd service request

Summary by CodeRabbit

  • New Features

    • Introduced a BOOLEAN DataType for enhanced attribute definition capabilities in the service request framework.
    • Implemented fixes for ExistentEntityValidator across multiple health services modules.
  • Version Updates

    • Updated service request module to version 1.0.1.
    • Updated household module to version 1.1.4.
    • Updated individual module to version 1.1.6.
    • Updated project module with validation for project start and end dates.
    • Updated stock module with enhancements to inventory flow.
  • Documentation

    • Updated changelogs for service request, household, individual, project, referral management, and stock modules to reflect recent changes and version updates.

Copy link
Contributor

coderabbitai bot commented Aug 29, 2024

Walkthrough

The recent updates include the release of version 1.0.1 for the service-request module, featuring the addition of a BOOLEAN DataType in AttributeDefinition. Additionally, the health-services modules have been updated, with versions 1.1.4 and 1.1.6 addressing fixes related to ExistentEntityValidator. Other modules also received updates, including version upgrades for dependencies and improvements in validation logic.

Changes

Files Change Summary
core-services/service-request/CHANGELOG.md Version 1.0.1 released; added BOOLEAN DataType in AttributeDefinition.
health-services/household/CHANGELOG.md Version 1.1.4 released; fixed formatting for "Core 2.9LTS" and addressed ExistentEntityValidator.
health-services/individual/CHANGELOG.md Version 1.1.6 released; addressed fixes related to ExistentEntityValidator.
health-services/project/CHANGELOG.md Noted fixes to ExistentEntityValidator, version upgrades for PostgreSQL driver, Flyway components, and validation for project dates.
health-services/referralmanagement/CHANGELOG.md Version 1.0.3 released; upgraded downsync logic and fixed ExistentEntityValidator.
health-services/stock/CHANGELOG.md Mentioned fixes to ExistentEntityValidator, version upgrades for PostgreSQL driver, Flyway components, and enhancements in inventory flow.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ServiceRequest
    participant AttributeDefinition

    User->>ServiceRequest: Create Service Request
    ServiceRequest->>AttributeDefinition: Define Attributes
    AttributeDefinition-->>ServiceRequest: Include BOOLEAN DataType
    ServiceRequest-->>User: Service Request Created
Loading

🐰 "In the fields where we hop and play,
New types of data brighten our day!
With BOOLEAN added, oh what a treat,
Our service requests are now quite neat!
Hooray for fixes, let’s dance and cheer,
For better health services, we hold dear!" 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 7

Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between e3d5238 and 09850dc.

Files selected for processing (6)
  • core-services/service-request/CHANGELOG.md (1 hunks)
  • core-services/service-request/pom.xml (1 hunks)
  • health-services/household/CHANGELOG.md (1 hunks)
  • health-services/household/pom.xml (1 hunks)
  • health-services/individual/CHANGELOG.md (1 hunks)
  • health-services/individual/pom.xml (1 hunks)
Additional context used
Markdownlint
core-services/service-request/CHANGELOG.md

3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


4-4: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)

health-services/individual/CHANGELOG.md

3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


4-4: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)

health-services/household/CHANGELOG.md

3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


6-6: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


4-4: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


7-7: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)

Additional comments not posted (3)
core-services/service-request/pom.xml (1)

7-7: LGTM!

The version update from 1.0.0 to 1.0.1 signifies backward-compatible improvements or bug fixes.

health-services/household/pom.xml (1)

8-8: LGTM!

The version update from 1.1.3 to 1.1.4 signifies backward-compatible improvements or bug fixes.

health-services/individual/pom.xml (1)

8-8: LGTM!

The version update from 1.1.5 to 1.1.6 signifies backward-compatible improvements or bug fixes.

core-services/service-request/CHANGELOG.md Show resolved Hide resolved
core-services/service-request/CHANGELOG.md Outdated Show resolved Hide resolved
health-services/individual/CHANGELOG.md Outdated Show resolved Hide resolved
health-services/individual/CHANGELOG.md Outdated Show resolved Hide resolved
health-services/household/CHANGELOG.md Outdated Show resolved Hide resolved
health-services/household/CHANGELOG.md Show resolved Hide resolved
health-services/household/CHANGELOG.md Show resolved Hide resolved
kavi-egov and others added 2 commits August 29, 2024 18:10
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 09850dc and a7b7015.

Files selected for processing (2)
  • core-services/service-request/CHANGELOG.md (1 hunks)
  • health-services/individual/CHANGELOG.md (1 hunks)
Additional context used
Markdownlint
core-services/service-request/CHANGELOG.md

5-5: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


6-6: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)

health-services/individual/CHANGELOG.md

6-6: Expected: 0; Actual: 1
Unordered list indentation

(MD007, ul-indent)


3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


4-4: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


4-4: null
Headings must start at the beginning of the line

(MD023, heading-start-left)


8-8: null
Headings must start at the beginning of the line

(MD023, heading-start-left)


4-4: null
Multiple headings with the same content

(MD024, no-duplicate-heading)

Additional comments not posted (4)
core-services/service-request/CHANGELOG.md (2)

3-3: Fix formatting: Surround headings with blank lines.

Headings should be surrounded by blank lines to improve readability.

-All notable changes to this module will be documented in this file.
+All notable changes to this module will be documented in this file.

 ## 1.0.1 - 2024-08-29

6-6: Fix formatting: Surround lists with blank lines.

Lists should be surrounded by blank lines to improve readability.

 ## 1.0.1 - 2024-08-29
- Added `BOOLEAN` DataType in `AttributeDefinition`
+ 
+ - Added `BOOLEAN` DataType in `AttributeDefinition`
+
 ## 1.0.0
Tools
Markdownlint

6-6: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)

health-services/individual/CHANGELOG.md (2)

3-3: Fix formatting: Surround headings with blank lines.

Headings should be surrounded by blank lines to improve readability.

-All notable changes to this module will be documented in this file.
+All notable changes to this module will be documented in this file.

 ## 1.1.6 - 2024-08-29
Tools
Markdownlint

3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


6-6: Fix formatting: Surround lists with blank lines.

Lists should be surrounded by blank lines to improve readability.

 ## 1.1.6 - 2024-08-29
- Added `ExistentEntityValidator` fixes
+ 
+ - Added `ExistentEntityValidator` fixes
+
 ## 1.1.5 - 2024-05-29
Tools
Markdownlint

6-6: Expected: 0; Actual: 1
Unordered list indentation

(MD007, ul-indent)

core-services/service-request/CHANGELOG.md Show resolved Hide resolved
health-services/individual/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between a7b7015 and 6ad644f.

Files selected for processing (2)
  • core-services/service-request/CHANGELOG.md (1 hunks)
  • health-services/individual/CHANGELOG.md (2 hunks)
Additional context used
Markdownlint
core-services/service-request/CHANGELOG.md

3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


4-4: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)

health-services/individual/CHANGELOG.md

5-5: Expected: 0; Actual: 1
Unordered list indentation

(MD007, ul-indent)

Additional comments not posted (3)
core-services/service-request/CHANGELOG.md (2)

3-3: Skip: Surround headings with blank lines.

Tools
Markdownlint

3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


4-4: Skip: Surround lists with blank lines.

Tools
Markdownlint

4-4: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)

health-services/individual/CHANGELOG.md (1)

3-3: Skip: Surround headings with blank lines and start at the beginning of the line.

health-services/individual/CHANGELOG.md Show resolved Hide resolved
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 6ad644f and 4a0e3be.

Files selected for processing (3)
  • core-services/service-request/CHANGELOG.md (1 hunks)
  • health-services/household/CHANGELOG.md (2 hunks)
  • health-services/individual/CHANGELOG.md (2 hunks)
Additional context used
Markdownlint
core-services/service-request/CHANGELOG.md

3-3: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)

health-services/individual/CHANGELOG.md

5-5: Expected: 0; Actual: 1
Unordered list indentation

(MD007, ul-indent)


3-3: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)


7-7: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)

health-services/household/CHANGELOG.md

3-3: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)


7-7: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)

core-services/service-request/CHANGELOG.md Show resolved Hide resolved
health-services/individual/CHANGELOG.md Show resolved Hide resolved
health-services/household/CHANGELOG.md Show resolved Hide resolved
@kanishq-egov
Copy link
Contributor Author

@coderabbitai review

Copy link
Contributor

coderabbitai bot commented Aug 30, 2024

Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 4a0e3be and c7129b5.

Files selected for processing (3)
  • health-services/project/CHANGELOG.md (1 hunks)
  • health-services/referralmanagement/CHANGELOG.md (1 hunks)
  • health-services/stock/CHANGELOG.md (1 hunks)
Additional context used
Markdownlint
health-services/project/CHANGELOG.md

16-16: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)

Additional comments not posted (3)
health-services/stock/CHANGELOG.md (1)

11-11: Documented changes approved.

The addition of ExistentEntityValidator fixes is crucial for ensuring data integrity and correct operation handling. It's good to see this documented clearly.

health-services/referralmanagement/CHANGELOG.md (1)

6-6: Documented changes approved.

The addition of ExistentEntityValidator fixes is crucial for ensuring data integrity and correct operation handling. It's good to see this documented clearly.

health-services/project/CHANGELOG.md (1)

16-16: Documented changes approved.

The addition of ExistentEntityValidator fixes is crucial for ensuring data integrity and correct operation handling. It's good to see this documented clearly.

Tools
Markdownlint

16-16: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)

health-services/project/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between c7129b5 and 84c382e.

Files selected for processing (1)
  • health-services/project/CHANGELOG.md (1 hunks)
Additional comments not posted (7)
health-services/project/CHANGELOG.md (7)

Line range hint 3-3: Changelog entry for version 1.1.5 is clear and concise.

The documentation of the new UserAction functionality with Location capture is well-documented and clear.

Tools
Markdownlint

18-18: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


19-19: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


Line range hint 5-12: Changelog entry for version 1.1.4 is detailed and informative.

The entry effectively documents multiple integrations and upgrades, including critical version upgrades for PostgreSQL Driver, Flyway base image, and Flyway-Core.

Tools
Markdownlint

18-18: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


19-19: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


16-18: Changelog entry for version 1.1.2 is comprehensive.

The documentation of validation for project dates and the addition of the numberOfSessions field is clear and adds significant value to the changelog.

Tools
Markdownlint

18-18: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


Line range hint 20-20: Changelog entry for version 1.1.1 is clear.

The addition of a tag in project beneficiary is well-documented.

Tools
Markdownlint

18-18: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


19-19: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


Line range hint 22-22: Changelog entry for version 1.1.1-beta is informative.

The documentation of support for multi-round and the addition of a new validator for project task is clear and detailed.

Tools
Markdownlint

18-18: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


19-19: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


Line range hint 24-24: Changelog entry for version 1.1.0 is concise.

The update to the models library version is clearly documented.

Tools
Markdownlint

18-18: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


19-19: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


Line range hint 26-26: Changelog entry for version 1.0.0 is clear.

The documentation of the base version is well-documented and clear.

Tools
Markdownlint

18-18: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


19-19: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)

@kavi-egov kavi-egov deleted the service-request-changelog-1.5 branch October 17, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants