Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed enum to Pascal_Case. #103

Merged
merged 4 commits into from
Oct 8, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions domain-services/fiscal-event-service/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog
All notable changes to this module will be documented in this file.

## 1.0.1 - 2021-10-08
- Fiscal-Event-Service receives the EventType enum of FiscalEvent model in ALL_CAPS but it will process it in
Pascal_Case. The record in the kafka topic will get the enum in Pascal_Case.

## 1.0.0 - 2021-09-24
- Baseline version released
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,9 @@ components:
maxLength: 64
minLength: 1
type: string
description: Captures the event type (eg- SANCTION(B), APPROPRIATION(B), ALLOCATION(FIN-AD-BCO-DDO)(B), INTRA_TRANSFER (C), INTER_TRANSFER (C), DEMAND(A), RECEIPT (C), BILL(A),PAYMENT (C)
description: Captures the event type (eg- SANCTION(B), APPROPRIATION(B), ALLOCATION(FIN-AD-BCO-DDO)(B), INTRA_TRANSFER(C), INTER_TRANSFER(C), DEMAND(A), RECEIPT(C), BILL(A), PAYMENT(C))
nullable: false
example: Appropriation
example: PAYMENT
eventTime:
type: integer
description: when the event occured at source system level
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,15 +64,15 @@ public class FiscalEvent {


public enum EventTypeEnum {
SANCTION("SANCTION"),
APPROPRIATION("APPROPRIATION"),
ALLOCATION("ALLOCATION"),
INTRA_TRANSFER("INTRA_TRANSFER"),
INTER_TRANSFER("INTER_TRANSFER"),
DEMAND("DEMAND"),
RECEIPT("RECEIPT"),
BILL("BILL"),
PAYMENT("PAYMENT");
Sanction("SANCTION"),
Appropriation("APPROPRIATION"),
Allocation("ALLOCATION"),
Intra_Transfer("INTRA_TRANSFER"),
Inter_Transfer("INTER_TRANSFER"),
Demand("DEMAND"),
Receipt("RECEIPT"),
Bill("BILL"),
Payment("PAYMENT");

private String value;

Expand All @@ -93,7 +93,7 @@ public static EventTypeEnum fromValue(String text) {
@Override
@JsonValue
public String toString() {
return String.valueOf(value);
return name();
}
}

Expand Down