ISTE-131,ISTE-132: Fixed numbers not allowing starting from 5, Removed HRMS roles from search and count

[anilsingha-eGov]

Summary by CodeRabbit

• Bug Fixes

  • Updated phone number validation pattern to allow numbers starting from 4-9 instead of 6-9.

• Improvements

  • Refined roles assignment for better clarity and consistency.
  • Enhanced readability and structure of role-related conditions and assignments.
  • Improved tenant ID assignment logic for better code clarity and consistency.

[coderabbitai]

Walkthrough

The recent updates primarily focus on refining the HRMS module's Inbox.js and hrmscard.js files. Key changes include modifying role assignments based on the STATE_ADMIN flag, enhancing code readability and consistency, and updating the phone number validation regex pattern. These adjustments aim to improve clarity, maintainability, and functionality within the HRMS module.

Changes

File Path	Change Summary
.../src/components/hrmscard.js	Adjusted declarations and exports of HRMSCard and propsForModuleCard.
.../src/pages/Inbox.js	Modified role assignments based on STATE_ADMIN, enhanced code formatting, refactored tenantId assignment, and updated phone number validation regex.

🐇✨ In code we trust, we tweak and mend,
Roles are clear, no rules to bend.
Patterns shift, from six to four,
Our HRMS, refined once more.
With each commit, we celebrate,
A system smooth, up-to-date!
🚀💻

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d902d20 and e06bf1f.

Files selected for processing (2)

• frontend/micro-ui/web/micro-ui-internals/packages/modules/hrms/src/components/hrmscard.js (2 hunks)
• frontend/micro-ui/web/micro-ui-internals/packages/modules/hrms/src/pages/Inbox.js (3 hunks)

Additional comments not posted (3)

frontend/micro-ui/web/micro-ui-internals/packages/modules/hrms/src/components/hrmscard.js (1)

17-21: Refined roles assignment logic for STATE_ADMIN.

The roles assignment logic has been updated to remove "HRMS_ADMIN" when STATE_ADMIN is true. This change is consistent with the PR objectives and improves the clarity of the roles assignment.

frontend/micro-ui/web/micro-ui-internals/packages/modules/hrms/src/pages/Inbox.js (2)

30-34: Refined roles assignment logic for STATE_ADMIN.

The roles assignment logic has been updated to remove "HRMS_ADMIN" when STATE_ADMIN is true. This change is consistent with the PR objectives and improves the clarity of the roles assignment.

---

133-133: Updated phone number validation pattern.

The phone number validation pattern has been updated from "[6-9][0-9]{9}" to "[4-9][0-9]{9}". This change allows phone numbers starting with 4 and 5, aligning with the PR objectives.