Respect TextureContents/Canvas::DrawImageRect source rect (flutter#22)

egramond · Apr 27, 2022 · cb9997a · cb9997a
1 parent 26090e4
commit cb9997a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/impeller/aiks/aiks_unittests.cc b/impeller/aiks/aiks_unittests.cc
@@ -59,7 +59,7 @@ TEST_F(AiksTest, CanRenderImage) {
   ASSERT_TRUE(OpenPlaygroundHere(canvas.EndRecordingAsPicture()));
 }
 
-TEST_F(AiksTest, DISABLED_CanRenderImageRect) {
+TEST_F(AiksTest, CanRenderImageRect) {
   Canvas canvas;
   Paint paint;
   auto image = std::make_shared<Image>(CreateTextureForFixture("kalimba.jpg"));

diff --git a/impeller/entity/contents.cc b/impeller/entity/contents.cc
@@ -229,11 +229,15 @@ bool TextureContents::Render(const ContentContext& renderer,
     const auto tess_result =
         Tessellator{entity.GetPath().GetFillType()}.Tessellate(
             entity.GetPath().CreatePolyline(),
-            [&vertex_builder, &coverage_rect](Point vtx) {
+            [this, &vertex_builder, &coverage_rect, &texture_size](Point vtx) {
               VS::PerVertexData data;
               data.vertices = vtx;
+              auto coverage_coords =
+                  (vtx - coverage_rect->origin) / coverage_rect->size;
               data.texture_coords =
-                  ((vtx - coverage_rect->origin) / coverage_rect->size);
+                  (source_rect_.origin +
+                   source_rect_.size * coverage_coords) /
+                  texture_size;
               vertex_builder.AppendVertex(data);
             });
     if (!tess_result) {