Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix directory path too long problem on windows #749

Closed
wants to merge 418 commits into from
Closed

Fix directory path too long problem on windows #749

wants to merge 418 commits into from

Conversation

edwardzjl
Copy link

Summary

Current version has some problems when installing npm on windows, because the installation will download a bunch of node modules in tmp dir and the path would look like "tmp/node/node_modules/module_a/node_modules/module_b/............."
But Windows cannot deal with paths longer than 247 chars.

This commit checks the path's length and will flattern any long path folder in the tmp dir, before they are deleted.

Tests and Documentation

Fix directory path too long problem on windows.

@Zardoz89
Copy link
Contributor

@edwardzjl Could do you do a rebase, so appveyor and travis can redo the tests ?

@edwardzjl
Copy link
Author

@Zardoz89 I dont know whats wrong, I can build successfully on my computer.
the appveyor log says could not transfer artifact org.sonatype.oss:oss-parent:pom:7 due to access denied

@Zardoz89
Copy link
Contributor

Appveyour fails randomly. I tried to fix it, but sometime keeps failing. I don't have clue why.

On this case, it worked with JDK 1.8 on Windows, and on Travis. So I would say to go with this, but @eirslett is who decide.

@Santoshbhad
Copy link

Thank you so much this helps me to fix this issue i need to just run below command
npm cache clean --force
mvn clean install

@eirslett
Copy link
Owner

Looks like a lot of unrelated changes in the same PR... could you please rebase and squash the commits so it's easier to review?

dilipramji and others added 23 commits February 18, 2019 18:25
This avoids manual version bumping in the tests after a new version of the
project has been released
Including incremental build modified files checking. Refreshing built files.

Adds triggerfiles, srcdir, outputdir parameters to the Grunt and Gulp mojos.
…ment

Removed with_new_path and set PATH variable from processbuilder

Fixed PATH Variable case sensivity issues on Windows

Fixed style conventions and removed extra logic for windows path variable name
Add link to Linux build
eirslett and others added 27 commits February 19, 2019 15:02
- remove separate yarn 1.x tests
- update default yarn tests to 1.6.0
- update package.json and node
- update package.json
- update node to latest lts
- update all other libs
- force tls1.2 (important for jdk 1.7 and github), this will fix tests on appveyor
- optimize code
This vulnerability is present in many open-source
projects because the particular code snippet has been
copy-pasted from project to project.
It's not a critical issue for frontend-maven-plugin,
because there is no viable attack vector that would
be closed by this patch. But the code here is patched
anyways, so that people who copy-paste the code will
have a patched copy of it.

The vulnerability was found by Snyk Security
Research Team.
Just updating the link to the Nexus documentation as the old link now redirects to a generic page for Nexus Repository Manager 2.
AppVeyor configuration to build and launch tsts against JDK 8 and 11
over a Windows machine.

Tested on https://ci.appveyor.com/project/Zardoz89/frontend-maven-plugin
AppVeyor configuration to build and launch tsts against JDK 8 and 11
over a Windows machine.

Tested on https://ci.appveyor.com/project/Zardoz89/frontend-maven-plugin
@edwardzjl edwardzjl closed this Feb 19, 2019
@paul-bjorkstrand
Copy link

This looks like a problem with Java/windows, and how Java needs to delete folders (deleting contents before deleting the folder, recursively). I think you just need to catch the error, and log out message saying that "the temp dir was not able to be deleted, please delete it manually: ".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.