Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keys Feature Addition #20

Merged
merged 15 commits into from
Apr 3, 2020
Merged

Keys Feature Addition #20

merged 15 commits into from
Apr 3, 2020

Conversation

Ajnbro
Copy link
Contributor

@Ajnbro Ajnbro commented Mar 26, 2020

Addresses the feature request found in issue #16. Creates execution and state modules for Key Vault Keys using operations found here. Additionally, it fixes the dependencies list for the key vaults execution state.

Copy link
Member

@nicholasmhughes nicholasmhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

idem_provider_azurerm/states/azurerm/keyvault/key.py Outdated Show resolved Hide resolved
idem_provider_azurerm/states/azurerm/keyvault/key.py Outdated Show resolved Hide resolved
idem_provider_azurerm/states/azurerm/keyvault/key.py Outdated Show resolved Hide resolved
idem_provider_azurerm/states/azurerm/keyvault/key.py Outdated Show resolved Hide resolved
idem_provider_azurerm/states/azurerm/keyvault/key.py Outdated Show resolved Hide resolved
@Ajnbro Ajnbro linked an issue Mar 26, 2020 that may be closed by this pull request
@Ajnbro Ajnbro added the Enhancement New feature or request label Mar 26, 2020
@Ajnbro Ajnbro removed their assignment Mar 26, 2020
@nicholasmhughes nicholasmhughes self-assigned this Mar 26, 2020
@nicholasmhughes nicholasmhughes merged commit 1898666 into master Apr 3, 2020
@nicholasmhughes nicholasmhughes deleted the keys branch April 3, 2020 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Create exec and state modules for KeyVault Keys
2 participants