-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add missing functions and docs for LazyFrame #31
base: main
Are you sure you want to change the base?
Conversation
@eitsupi I start testing those functions and I find it a bit hard to read this kind of tests: expect_query_equal(
.input$select("int32"),
.data,
pl$DataFrame(int32 = 1:5)
) I think it's a good idea to test LazyFrame and DataFrame functions at once instead of manually copying tests, but the function above cannot take multiple datasets when testing joins for example. In This way, I can just write tests for DataFrame and it automatically generates the same tests for LazyFrame. It's also easier to see if an error only happens for eager/lazy data since tests appear in different files. What do you think about this approach? |
ce105a6
to
fe1ef97
Compare
Sorry I did not notice the mention.
I think it's a good idea, but it may be difficult given the support for tests for things like head that behave differently in LazyFrame and DataFrame? I'm also concerned about the possibility of files being updated on CI if run as part of
Could this be addressed by updating the function? |
No description provided.