Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: only do network IO when accessed #2

Merged
merged 1 commit into from
Oct 16, 2015
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/hu/ssh/github_changelog.clj
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@
(defn changelog
"Fetches the changelog"
[user repo]
(let [tags (map #(assoc % :version (parse-semver %)) (repos/tags user repo))
pulls (pulls/pulls user repo {:state "closed"})
commits (repos/commits user repo)]
(println (first tags))))
(let [tags (delay (map #(assoc % :version (parse-semver %)) (repos/tags user repo)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in love :)

pulls (delay (pulls/pulls user repo {:state "closed"}))
commits (delay (repos/commits user repo))]
(println (first @tags))))

(core/with-defaults {:oauth-token (env :github-token) :all_pages true}
(changelog "raszi" "node-tmp"))