Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter groups #71

Closed
wants to merge 3 commits into from
Closed

feat: filter groups #71

wants to merge 3 commits into from

Conversation

ekristen
Copy link
Owner

This adds the filter group feature to libnuke.

By default if group is not specified, all filters are part of the default group.

All filters within a group are OR operator together. All filter groups are AND together.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.64%. Comparing base (71dd5d0) to head (5f865e9).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
pkg/filter/filter.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   97.78%   97.64%   -0.14%     
==========================================
  Files          17       17              
  Lines        1084     1105      +21     
==========================================
+ Hits         1060     1079      +19     
- Misses         13       14       +1     
- Partials       11       12       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekristen
Copy link
Owner Author

Superseded by #79

@ekristen ekristen closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant