Merge pull request #193 from weaveworks/linting

Add linting target

.gometalinter.json

@@ -0,0 +1,6 @@
+{
+    "Errors": true,
+    "Enable": ["vet", "golint", "errcheck", "deadcode"],
+    "Exclude": ["^vendor\/", "^build\/"],
+    "Deadline": "5m"
+}

Dockerfile

@@ -29,7 +29,7 @@ ARG COVERALLS_TOKEN
 ENV COVERALLS_TOKEN $COVERALLS_TOKEN
 
 WORKDIR $EKSCTL
-RUN make test && make \
+RUN make lint && make test && make \
     && cp ./eksctl /out/usr/local/bin/eksctl
 
 RUN go build ./vendor/github.com/heptio/authenticator/cmd/heptio-authenticator-aws \

Makefile

@@ -19,6 +19,14 @@ test: generate
 	@go test -v -covermode=count -coverprofile=coverage.out ./pkg/... ./cmd/...
 	@test -z $(COVERALLS_TOKEN) || goveralls -coverprofile=coverage.out -service=circle-ci
 
+.PHONY: lint
+lint:
+	@gometalinter ./...
+
+.PHONY: ci
+ci: test lint
+
+
 .PHONY: integration-test-dev
 integration-test-dev: build
 	@go test -tags integration -v -timeout 21m ./tests/integration/... \

build/install.sh

@@ -1,7 +1,28 @@
-#!/bin/sh
+#!/bin/sh -eu
 
 go install ./vendor/github.com/jteeuwen/go-bindata/go-bindata
 go install ./vendor/github.com/weaveworks/github-release
 go install ./vendor/golang.org/x/tools/cmd/stringer
 go install ./vendor/github.com/mattn/goveralls
 go install ./vendor/github.com/vektra/mockery/cmd/mockery
+
+# managing all linters that gometalinter uses with dep is going to take
+# a lot of work, so we install all of those from the release tarball
+install_gometalinter() {
+  version="${1}"
+  prefix="https://github.com/alecthomas/gometalinter/releases/download"
+  if [ "$(uname)" = "Darwin" ] ; then
+    suffix="darwin-amd64"
+  else
+    suffix="linux-amd64"
+  fi
+  basename="gometalinter-${version}-${suffix}"
+  url="${prefix}/v${version}/${basename}.tar.gz"
+  cd "${GOPATH}/bin/"
+  curl --silent --location "${url}" | tar xz
+  (cd "./${basename}/" ; mv ./* ../)
+  rmdir "./${basename}"
+  unset version prefix suffix basename url
+}
+
+install_gometalinter "2.0.11"