incorrect usage of k8s.io/kubernetes #1537
Assignees
Labels
Comments
|
This specific usage of |
michaelbeaumont
added a commit
to michaelbeaumont/eksctl
that referenced
this issue
Jun 10, 2020
According to golang/go#32776 (comment), it's not supposed to be used as a dependency. Additionally, I think this code might end up being removed if we agree with golang/go#32776 (comment). Closes eksctl-io#1537
5 tasks
michaelbeaumont
added a commit
to michaelbeaumont/eksctl
that referenced
this issue
Jun 10, 2020
According to golang/go#32776 (comment), it's not supposed to be used as a dependency. Additionally, I think this code might end up being removed if we agree with eksctl-io#2197 (comment). Closes eksctl-io#1537
michaelbeaumont
added a commit
to michaelbeaumont/eksctl
that referenced
this issue
Jun 10, 2020
According to golang/go#32776 (comment), it's not supposed to be used as a dependency. Additionally, I think this code might end up being removed if we agree with eksctl-io#2197 (comment). Closes eksctl-io#1537
|
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
Duplicate of #813 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
When importing
eksctlas a library, I pull ink8s.io/kubernetesas a transitive dependency.I would like to use the
k8s.io/kubernetes/pkg/cloudprovider/providers/awspackage version that is compatible with the otherkubernetes-1.12.6libraries that I am importing. I am aware that we should not importk8s.io/kubernetesdirectly, per kubernetes/kubernetes#81878. I looked in kubernetes/cloud-providers-aws, however I do not see anykubernetes-1.12.6tag and the code was removed at kubernetes/cloud-provider-aws@b377713.What you expected to happen?
Customers should not import
k8s.io/kubernetesdirectly, see kubernetes/kubernetes#81878, and instead using component modules:k8s.io/cloud-providerandk8s.io/cloud-provider-aws.Anything else we need to know?
I would have submitted this as a PR, since the
k8s.io/cloud-providerfix is just afind -exec sed, unfortunately I am unclear what the best candidate for replacingk8s.io/kubernetes/pkg/cloudprovider/providers/awsis. kubernetes/cloud-providers-aws does not have any tags, let alonekubernetes-1.12.6, and the related logic was removed: kubernetes/cloud-provider-aws@b377713. As such, I have created an upstream ticket to track the need: kubernetes/kubernetes#85022.The text was updated successfully, but these errors were encountered: