Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] warning on missing launch template when using mixed instance type node group #7644

Closed
vandamb opened this issue Mar 13, 2024 · 0 comments · Fixed by #7661
Closed

[Bug] warning on missing launch template when using mixed instance type node group #7644

vandamb opened this issue Mar 13, 2024 · 0 comments · Fixed by #7661
Labels

Comments

@vandamb
Copy link

vandamb commented Mar 13, 2024

What were you trying to accomplish?

Scaling up an (unmanaged) nodegroup which has mixed instances (using instancesDistribution)

What happened?

The scale up throws a warning that no launch template can be found (even if one exists). The actual scale up succeeds, but the warning is wrong.

How to reproduce it?

eksctl scale ng --cluster <cluster_name> --nodes=2 --nodes-min=0 --nodes-max=4 <ng_name>

Logs
2024-03-13 10:12:46 [!] nodegroup with Auto Scaling group "ng_name" does not have a launch template

Anything else we need to know?
I think it is related to the output of the aws autoscaling describe-auto-scaling-groups, which returns a different structure in case mixed instance policy is applied. eksctl expects LaunchTemplate as a top level property in the ASG struct, but for mixed instance node groups the property is nested one level deeper under the MixedInstancesPolicy property (so launch template is in MixedInstancesPolicy.LaunchTemplate)

Versions
eksctl version: 0.162.0
kubectl version: v1.26.9
OS: linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant