Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include MixedInstancesPolicy LaunchTemplate for validation #7661

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Include MixedInstancesPolicy LaunchTemplate for validation #7661

merged 1 commit into from
Mar 22, 2024

Conversation

yuxiang-zhang
Copy link
Member

@yuxiang-zhang yuxiang-zhang commented Mar 14, 2024 •
edited
Loading

Description

Fixes #7644

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

TiberiuGC
TiberiuGC reviewed Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@TiberiuGC TiberiuGC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add an unit test for this?

@yuxiang-zhang
Copy link
Member Author

Can we add an unit test for this?

👍 will do, I'm trying to confirm whether this solution is correct

@yuxiang-zhang yuxiang-zhang merged commit cfec0d9 into eksctl-io:main Mar 22, 2024
9 checks passed
@yuxiang-zhang yuxiang-zhang deleted the 7644 branch March 22, 2024 21:01
@eksctl-bot eksctl-bot mentioned this pull request Mar 30, 2024
Merged
@eksctl-bot eksctl-bot mentioned this pull request Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TiberiuGC TiberiuGC TiberiuGC approved these changes

@cPu1 cPu1 Awaiting requested review from cPu1

@a-hilaly a-hilaly Awaiting requested review from a-hilaly

Assignees
No one assigned
Labels
area/nodegroup kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] warning on missing launch template when using mixed instance type node group
2 participants
@yuxiang-zhang @TiberiuGC