-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AZ selector logic #124
Conversation
We have test and they are failing, isn't that nice? 😺 📣 😻 |
@richardcase tests LGTM, thank you! |
When trying to create a cluster with this i get the following error:
Looking at the debug output i can see the availability zones are passed in as a parameter but not sure whats going wrong:
Not sure how i update the template. |
Added test around SelectAvailabilityZones. Also changed the function to return an array of zones instead of mutating ClusterProvider.Status directly.
Changed the availability zone selection code. Moved into a different package, added filters to the AWS call and allowed zone selection to be changed in the future.
e4cd213
to
b843db5
Compare
@richardcase that error was because we forgot to re-genrate biodata for the templates. |
b843db5
to
5be66cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I have tested the cluster creation since the template change and it sets the AZs correctly.
Fixes #118 and #101.