Get cluster fixes #153
Merged
Get cluster fixes #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.vscode/launch.json
Outdated
| @@ -0,0 +1,44 @@ | |||
| { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
pkg/testutils/cluster.go
Outdated
| // ValidClusterStatus checks that the provided status is a valid | ||
| // status of a cluster according to AWS SDK | ||
| func ValidClusterStatus(status string) bool { | ||
| valid := map[string]bool{awseks.ClusterStatusActive: true, awseks.ClusterStatusCreating: true, awseks.ClusterStatusDeleting: true, awseks.ClusterStatusFailed: true} |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
richardcase
force-pushed
the
get-cluster-fixes
branch
from
9dc005c
to
3e15d01
Compare
errordeveloper
previously approved these changes
Aug 10, 2018
Update the list clusters tests to ensure we cover the scenario where a cluster isn't ready.
richardcase
force-pushed
the
get-cluster-fixes
branch
from
3e15d01
to
10b9f96
Compare
errordeveloper
approved these changes
Aug 10, 2018
torredil
pushed a commit
to torredil/eksctl
that referenced
this pull request
May 20, 2022
Move test integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the 'list clusters' functionality:
No clusters foundwill be output. If you are using the JSON or YAML printers then an empty array is returned. Fixes eksctl get clusters output is confusing when no clusters a present #146.ClusterStatusActivethen it will still print its details. Before this it was ignored. Fixes eksctl get clusters is not clear about cluster status #145.