Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests #171

Merged
merged 7 commits into from
Aug 31, 2018
Merged

Integration tests #171

merged 7 commits into from
Aug 31, 2018

Conversation

richardcase
Copy link
Contributor

@richardcase richardcase commented Aug 22, 2018 •
edited by errordeveloper
Loading

Description

This is WIP progress for the integration tests. For #151

Checklist

  • Code compiles correctly (i.e make build)
  • Added tests that cover your change (if possible)
  • All tests passing (i.e. make test)
  • Added/modified documentation as required (such as the README)
  • Added yourself to the humans.txt file

@coveralls
Copy link

coveralls commented Aug 22, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 947

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 20 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 14.985%
Files with Coverage Reduction New Missed Lines %
pkg/eks/auth.go 20 0.0%
Totals Coverage Status
Change from base Build 922: 0.0%
Covered Lines: 205
Relevant Lines: 1368
💛 - Coveralls

@richardcase @errordeveloper
Initial checkin on integration test
5a3ad09 
This is WIP and just to show the approach.
@errordeveloper errordeveloper force-pushed the integration-tests branch 4 times, most recently from 0959b01 to d5a5cc7 Compare August 30, 2018 14:55
@richardcase @errordeveloper
Added gomega matchers to hide away some of the aws plumbing
8a5d762
@richardcase @errordeveloper
Added additional stack tests. Added make file target for tests
2c91351
@richardcase @errordeveloper
Added cleanup and did some refactoring
82004a3
@richardcase @errordeveloper
Added deployment test
44cf76d 
Started to add deployment test to test that we can deploy to kubernetes.
This isn't working at present. Also, had to comment out the
kubectl test due to a glog issue with flags.
@errordeveloper errordeveloper force-pushed the integration-tests branch 2 times, most recently from 3f4996f to 0085e76 Compare August 30, 2018 15:10
richardcase
richardcase commented Aug 30, 2018
View reviewed changes
Copy link
Contributor Author

@richardcase richardcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes and additions are looking good. It would be good if we could get the kubeconfig test also working (i ran out of time before holiday to look at the glog issues).

tests/integration/create_get_delete/integration_test.go Outdated
)

func TestCreateIntegration(t *testing.T) {
RegisterFailHandler(Fail)
RunSpecs(t, "Integration - Create Suite")
}

type tInterface interface {

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

Makefile
@@ -17,9 +17,18 @@ test:
@go test -v -covermode=count -coverprofile=coverage.out ./pkg/... ./cmd/...
@test -z $(COVERALLS_TOKEN) || goveralls -coverprofile=coverage.out -service=circle-ci

.PHONY: integration-test-dev
integration-test-dev: build

This comment was marked as abuse.

Sign in to view

tests/integration/create_get_delete/integration_test.go Outdated
args := []string{"create", "cluster", "-n", clusterName, "-t", "t2.medium", "-N", "1", "-r", eksRegion, "--kubeconfig", pathToEksCtl}
fmt.Printf("Using kubeconfig: %s\n", kubeconfigPath)

if clusterName == "" {

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

tests/integration/create_get_delete/integration_test.go Outdated
Expect(err).ShouldNot(HaveOccurred())
//TODO: compare response???
}
// Expect(err).ShouldNot(HaveOccurred())

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

@errordeveloper
Copy link
Contributor

This works now, I just need to make another PR against kube-test-harness to fix PodProxyGet

@errordeveloper errordeveloper changed the title WIP: Integration tests Integration tests Aug 31, 2018
@errordeveloper
Copy link
Contributor

I've fixed dlespiau/kube-test-harness#21 and dlespiau/kube-test-harness#23, this is ready to go once my manual test succeeds.

errordeveloper
errordeveloper reviewed Aug 31, 2018
View reviewed changes
tests/integration/create_get_delete/integration_test.go
Expect(session).To(HaveCfnStack(fmt.Sprintf("EKS-%s-DefaultNodeGroup", clusterName)))
})

It("should have created a valid kubectl config file", func() {

This comment was marked as abuse.

Sign in to view

@errordeveloper errordeveloper merged commit 142fd2b into master Aug 31, 2018
@errordeveloper errordeveloper deleted the integration-tests branch August 31, 2018 14:30
torredil pushed a commit to torredil/eksctl that referenced this pull request May 20, 2022
@k8s-ci-robot
Merge pull request eksctl-io#171 from mesosphere/csi-images
4cdb503 
CSI image version and deployment manifests updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@errordeveloper errordeveloper errordeveloper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richardcase @coveralls @errordeveloper