Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable inter-nodegroup DNS access #418

Merged
merged 3 commits into from
Jan 10, 2019
Merged

Conversation

errordeveloper
Copy link
Contributor

@errordeveloper errordeveloper commented Jan 10, 2019

Description

With the introduction of multi-nodegroup support, we have missed the fact that node ports below 1025 are not open (accept for 22 being controller by --ssh-access, and 443 being open only to the EKS control plane). We might need to widen internal port access in the future (see #419), but for now we have to open DNS port, as it cripples the functionality of a multi-nodegroup cluster.

Fixes #414.

For discussion of full stricter isolation, see #417.

Checklist

  • Code compiles correctly (i.e make build)
  • Added tests that cover your change (if possible)
  • All tests passing (i.e. make test)
  • Provide path for users with broken nodegroups - will do in another PR

@errordeveloper errordeveloper force-pushed the enable-inter-nodegroup-dns branch 3 times, most recently from 5036574 to 275aeb8 Compare January 10, 2019 15:20
@errordeveloper errordeveloper merged commit 7ae0c35 into master Jan 10, 2019
@errordeveloper errordeveloper mentioned this pull request Jan 11, 2019
2 tasks
@dlespiau dlespiau deleted the enable-inter-nodegroup-dns branch January 11, 2019 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants