Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow mutating control plane subnets and security groups #7218

Merged
merged 6 commits into from
Oct 24, 2023
Merged

Allow mutating control plane subnets and security groups #7218

merged 6 commits into from
Oct 24, 2023

Conversation

cPu1
Copy link
Collaborator

@cPu1 cPu1 commented Oct 24, 2023 •
edited
Loading

Description

This changelist adds support for updating control plane subnets and security groups.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@cPu1 cPu1 added the kind/feature New feature or request label Oct 24, 2023
@cPu1 cPu1 force-pushed the cluster-subnets-security-groups branch from fb2e94c to 0a9efab Compare October 24, 2023 06:27
@cPu1 cPu1 force-pushed the cluster-subnets-security-groups branch from 0a9efab to c2c91ab Compare October 24, 2023 08:07
@cPu1 cPu1 enabled auto-merge October 24, 2023 08:08
@cPu1 cPu1 merged commit 72605fb into eksctl-io:main Oct 24, 2023
9 of 10 checks passed
@TiberiuGC TiberiuGC mentioned this pull request Apr 18, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TiberiuGC TiberiuGC TiberiuGC approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cPu1 @TiberiuGC