Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build image go version to 1.21 #7561

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Update build image go version to 1.21 #7561

merged 1 commit into from
Feb 15, 2024

Conversation

yuxiang-zhang
Copy link
Member

Description

Update build image manifest, tag file and workflows
Missed updating go versions in .golangci.yml and build/docker/Dockerfile as part of #7554

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@yuxiang-zhang
Update build image go version to 1.21
389f689 
Update build image manifest, tag file and workflows
@yuxiang-zhang yuxiang-zhang added skip-release-notes Causes PR not to show in release notes dependencies Pull requests that update a dependency file area/tech-debt Leftover improvements in code, testing and building labels Feb 15, 2024
a-hilaly
a-hilaly approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yuxiang-zhang yuxiang-zhang merged commit 123b48d into main Feb 15, 2024
13 checks passed
@yuxiang-zhang yuxiang-zhang deleted the build-img branch February 15, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

Assignees
No one assigned
Labels
area/tech-debt Leftover improvements in code, testing and building dependencies Pull requests that update a dependency file skip-release-notes Causes PR not to show in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuxiang-zhang @a-hilaly