Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove slackToken #7570

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

yuxiang-zhang
Copy link
Member

Description

Remove the leftover slackTokens

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@yuxiang-zhang yuxiang-zhang added kind/bug skip-release-notes Causes PR not to show in release notes area/tech-debt Leftover improvements in code, testing and building area/ci labels Feb 16, 2024
@yuxiang-zhang yuxiang-zhang merged commit 15a9f6e into eksctl-io:main Feb 16, 2024
13 checks passed
@yuxiang-zhang yuxiang-zhang deleted the remove-slack-token branch February 16, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci area/tech-debt Leftover improvements in code, testing and building kind/bug skip-release-notes Causes PR not to show in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants