Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate PR with release notes draft #7604

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

yuxiang-zhang
Copy link
Member

Description

Previously for new releases, the maintainers have to manually copy release notes from drafts, commit the file and open PR.

This PR automates that process by having the same workflow update a PR for the new release notes.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@yuxiang-zhang yuxiang-zhang added kind/improvement area/tech-debt Leftover improvements in code, testing and building area/ci labels Feb 23, 2024
@yuxiang-zhang yuxiang-zhang marked this pull request as ready for review February 23, 2024 23:41
a-hilaly
a-hilaly previously approved these changes Feb 27, 2024
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
/lgtm

@yuxiang-zhang yuxiang-zhang merged commit f1fa4a1 into eksctl-io:main Feb 27, 2024
9 checks passed
@yuxiang-zhang yuxiang-zhang deleted the automate-release-draft branch February 27, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci area/tech-debt Leftover improvements in code, testing and building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants