Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign EFA network interface device index 1 to additional network cards #7643

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

yuxiang-zhang
Copy link
Member

Description

Fixes #7520

ASG has addressed the previous limitation where we can't assign the same device index to different network cards. This PR makes the configuration to work across all instance types.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@yuxiang-zhang yuxiang-zhang marked this pull request as ready for review March 13, 2024 01:05
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
/lgtm

@yuxiang-zhang yuxiang-zhang merged commit 22195e4 into eksctl-io:main Mar 13, 2024
9 of 10 checks passed
@yuxiang-zhang yuxiang-zhang deleted the fix-efa branch March 13, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Cannot create cluster with p5 and efa enabled.
2 participants