Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix creating pod identities #7727

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Fix creating pod identities #7727

merged 2 commits into from
Apr 25, 2024

Conversation

cPu1
Copy link
Collaborator

@cPu1 cPu1 commented Apr 25, 2024 •
edited
Loading

Description

Replaces usage of a per-loop variable with a per-iteration variable.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@cPu1
Fix creating pod identities
b17d037 
Replaces usage of a per-loop variable with a per-iteration variable.
@cPu1 cPu1 added the skip-release-notes Causes PR not to show in release notes label Apr 25, 2024
@cPu1 cPu1 marked this pull request as ready for review April 25, 2024 17:49
@cPu1 cPu1 merged commit c9ee358 into eksctl-io:main Apr 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TiberiuGC TiberiuGC TiberiuGC approved these changes

Assignees
No one assigned
Labels
skip-release-notes Causes PR not to show in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cPu1 @TiberiuGC