Make RustPad just-enough compatible with EtherPad URLs #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, I like the idea! Down to merge this if the CI works. |
ntninja
force-pushed
the
feat-etherpad-url-compat
branch
from
eda688a
to
fe33cf0
Compare
… fragment in the displayed URL if received like this
App state that doesn’t correspond to anything in the EtherPad documentation
has its own destinct names assigned.
Combined with the previous commit this allows RustPad to be opened as:
https://path/to/rustpad/SomePadName?userName=AUserName&other=param
… which is just-enough compatible with Jitsi-Meet’s EtherPad integration to
make Rustpad a suitable drop-in replacement in that context.
ntninja
force-pushed
the
feat-etherpad-url-compat
branch
from
fe33cf0
to
86e381c
Compare
|
I just found https://docs.etherpad.org/api/embed_parameters.html which documents the EtherPad parameter list and I found that aside from There are now also comments about the supported and unsupported parameters that should be helpful and I restructured the code to have all the URL handling in the now renamed Let me know what you think! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows RustPad to work as a drop-in alternative for services that have basic EtherPad (popular collaborative document editing tool) integration using an IFrame
Really, it just extracts the two key pieces of information when invoked like:
https://path/to/rustpad/SomePadName?some=param&userName=AUserName&other=param
but that is enough to make it useful in the context of the “Collaborative Editing” (=EtherPad) support in the Jitsi Meet video conferencing solution. (SomePadName will be the name of the Jitsi Meet conference and AUserName the name of the currently logged in user.)
Based on #75, no real dependency through.