Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Environment.MachineName to get HostName #1509

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Use Environment.MachineName to get HostName #1509

merged 1 commit into from
Oct 5, 2021

Conversation

gregkalapos
Copy link
Contributor

Solves #1504

Other agents seem to do similar things based on elastic/apm#517 what Environment.MachineName does internally.

On Windows Environment.MachineName ends up in GetComputerNameW, on Unix it uses gethostname.

Use Environment.MachineName to get HostName.
@gregkalapos gregkalapos self-assigned this Oct 4, 2021
@apmmachine
Copy link
Contributor

apmmachine commented Oct 4, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-04T16:04:46.027+0000

  • Duration: 60 min 20 sec

  • Commit: 60d8542

Test stats 🧪

Test Results
Failed 0
Passed 19725
Skipped 126
Total 19851

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

@gregkalapos gregkalapos changed the title Use Environment.MachineName to get HostName. Use Environment.MachineName to get HostName Oct 4, 2021
@gregkalapos gregkalapos merged commit bd08098 into elastic:master Oct 5, 2021
@gregkalapos gregkalapos deleted the HostNameDetectionFix branch October 5, 2021 18:06
@russcam russcam added v1.12.0 bug Something isn't working labels Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-dotnet bug Something isn't working v1.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants